Re: [libvirt] [RFC PATCH 04/10] qemu: Introduce virTheadPoolDrain
On Mon, Jan 15, 2018 at 05:51:28PM +0100, Erik Skultety wrote:
On Wed, Jan 10, 2018 at 12:23:29PM -0500, John Ferlan wrote:
> Split up virThreadPoolFree to create a Drain function which will
> be called from virNetServerClose in order to ensure the various
> worker threads are removed during the close rather than waiting
> for the dispose function.
>
> Signed-off-by: John Ferlan <jferlan(a)redhat.com>
> ---
I think that Dan had a bit different idea about the virThreadPoolDrain (I think
that the name should have been something like virThreadPoolJobsPurge) function.
https://www.redhat.com/archives/libvir-list/2017-December/msg00802.html
Yep, this impl in John's patch is more akin to a StopWorkers()
method, than a Drain() method. To me "Drain" implies the workers
are still available to process further jobs
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|