On Fri, Dec 12, 2008 at 06:51:52PM +0100, Jim Meyering wrote:
Daniel Veillard <veillard@redhat.com> wrote:
On Fri, Dec 12, 2008 at 01:38:58PM +0100, Jim Meyering wrote:
Here's the change to remove the few remaining CVS $Id$ strings: Looks fine by me, I just hope the translators won't add some back. Maybe it's worth adding to syntax-check ?
Good idea.
That made me look for all of them, not just the few I thought of on the spot. And running the new check exposed two more:
$ make sc_prohibit_cvs_keyword docs/Goals:29:$Date$ python/TODO:8:$Date$ Makefile.maint: do not use CVS keyword expansion make: *** [sc_prohibit_cvs_keyword] Error 1
So this adds the new check and removes the violations:
Urgh $Date$ in text files is an old bad habit of mine :-) because it's someohow useful to know how outdated the information is, but CVS ids are not a good idea in retrospect even for this +1 Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/