Re: [libvirt] [PATCH 1/4] vmx: add VIR_DOMAIN_DEF_FEATURE_NO_BOOT_ORDER

On Tue, May 29, 2018 at 09:30:05AM +0200, Peter Krempa wrote: > On Mon, May 28, 2018 at 15:54:02 +0200, Ján Tomko wrote: > > Further patches will introduce validation and a default setting > > of def->os.bootDevs in postParse. > > > > Introduce a feature flag to opt out of this and set it in the vmx > > driver. > > This does not clarify in any way why it is required. > Introduce a feature flag to opt out of this and set it in the vmx driver, otherwise we would be adding it <boot dev='hd'/> into every vmx config despite having no way to change it.

(Alternatively, if booting from hard-drive is the default, we can just leave it in because none of the vmx code even touches bootDevs, so it will be safely ignored)

Jano > > > > Signed-off-by: Ján Tomko <jtomko(a)redhat.com&gt; > > --- > > src/conf/domain_conf.h | 1 + > > src/vmx/vmx.c | 3 ++- > > 2 files changed, 3 insertions(+), 1 deletion(-)

-- libvir-list mailing list libvir-list(a)redhat.com https://www.redhat.com/mailman/listinfo/libvir-list