Re: [PATCH 03/18] hw/audio: Simplify hda audio init
On Mon, Apr 25, 2022 at 10:21:46AM +0200, Martin Kletzander wrote:
No return values are used anywhere, so switch the functions to be
void
and add support for error reporting using errp for use in next patches.
Making it 'void' makes sense, but I'm not sure we need the Error **errp
addition, given my comment on patch #13.
Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com>
---
hw/audio/hda-codec.c | 32 ++++++++++++++++++--------------
hw/audio/intel-hda.c | 4 +---
hw/audio/intel-hda.h | 2 +-
3 files changed, 20 insertions(+), 18 deletions(-)
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|