On 10/4/23 07:58, Narayana Murty N wrote:
The function virHostCPUGetPhysAddrSize was introduced with commit be1b7d5b18e fails on architectures other than x86 and SuperH. The commit 8417c1394cd4d fixed the issue only for s390 but the problem is still seen on other architectures like ppc which does not report Physical address size in their cpuinfo output.
command: systemctl restart libvirtd.service Output : <snip> dnsmasq[2377]: read /var/lib/libvirt/dnsmasq/default.addnhosts - 0 addresses dnsmasq-dhcp[2377]: read /var/lib/libvirt/dnsmasq/default.hostsfile libvirtd[3163]: libvirt version: 9.8.0 libvirtd[3163]: hostname: xxxxxxxxxx libvirtd[3163]: internal error: Missing or invalid CPU address size in /proc/cpuinfo libvirtd.service: Deactivated successfully. </snip>
This patch fixes this issue by returning the size=0 for architectures other than x86 and SuperH.
Signed-off-by: Narayana Murty N <nnmlinux@linux.ibm.com> --- src/util/virarch.h | 3 +++ src/util/virhostcpu.c | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-)
Whoa, I had no idea that SH is still alive (an well?). Reviewed-by: Michal Privoznik <mprivozn@redhat.com> and pushed. Congratulations on your first libvirt contribution. Michal