Re: [libvirt] [libvirt-glib 2/4] Implement gvir_config_domain_disk_[gs]et_driver()
On Fri, Jan 17, 2014 at 2:15 PM, Christophe Fergeau <cfergeau(a)redhat.com> wrote:
On Thu, Jan 16, 2014 at 07:48:31PM +0000, Zeeshan Ali (Khattak)
wrote:
> On Fri, Dec 6, 2013 at 11:13 AM, Christophe Fergeau <cfergeau(a)redhat.com>
wrote:
> > G_BEGIN_DECLS
> >
> > +/* These enum definitions are needed by libvirt-gconfig-domain-disk-driver.h
*/
>
> Why not just move these enums to that header then?
Inaccurate comment, I'll change it to "These enum definitions are also used by
libvirt-gconfig-domain-disk-driver.h". The comment is meant to explain why
the enums are defined before
#include <libvirt-gconfig/libvirt-gconfig-domain-disk-driver.h>
Yeah I understood. What I failed to explain was that these enums seem
more appropiate in libvirt-gconfig-domain-disk-driver.h and since its
being included here, you wont have to explain anything here or have
anything to explain at all.
--
Regards,
Zeeshan Ali (Khattak)
FSF member#5124