Re: [libvirt] [PATCH] Use camelCase for XML attribute numQueues
On Thu, Apr 18, 2013 at 08:27:56AM -0600, Eric Blake wrote:
On 04/18/2013 03:02 AM, Martin Kletzander wrote:
> In commit d4bf0a9, we used num_queues for an attribute in the XML, but
> the consensus is that we use camelCase for that. Since there was no
> release yet (the above commit describes as v1.0.4-65-gd4bf0a9), we
> still have time to change it.
You may want to wait for DV's opinion on naming, but I wasn't aware that
we had a consensus on camelCase. In fact, '_' is currently winning,
although it's hard to say whether that is limited to older interfaces.
Hum, I don't think I ever suggested such rules at the XML level.
We have that convention for code, as eric pointed out it is not as clear
for XML (and unfortunately we can't hamonize at this point without
quite a bit of churn - we would have to support the old syntax forever
anyway).
I don't have a strong opinion on _ vs. camelcase for markup,
I guess the exact same arguments can be raised pros/cons on visibility
and existing use :-\
Seems Eric is rather adverse to _ which was looking like the winner,
I dislike '-' myself as it is used for comments, and very uncommon
in identifiers in XML (well it's barred from being in an identifier
in most language).
If Eric really can't stand '_' then maybe the simplest is really
to start standardizing on camelCase,
Daniel
--
Daniel Veillard | Open Source and Standards, Red Hat
veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
http://veillard.com/ | virtualization library http://libvirt.org/