Re: [libvirt] [PATCH v2 11/31] qemu: Flatten qemuMonitorCPUDefs.cpus

Wednesday, 16 October 2019


On Tue, Oct 15, 2019 at 05:34:47PM +0200, Jiri Denemark wrote:
...
Let's store qemuMonitorCPUDefInfo directly in the array of CPUs
in
qemuMonitorCPUDefs rather then using an array of pointers.

Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com&gt;
Reviewed-by: Ján Tomko <jtomko(a)redhat.com&gt;
---

Notes:
    Version 2:
    - trivial rebase

 src/qemu/qemu_capabilities.c | 14 +++++++-------
 src/qemu/qemu_monitor.c      |  5 ++---
 src/qemu/qemu_monitor.h      |  2 +-
 src/qemu/qemu_monitor_json.c |  7 +------
 tests/qemumonitorjsontest.c  |  8 ++++----
 5 files changed, 15 insertions(+), 21 deletions(-)
 
Reviewed-by: Ján Tomko <jtomko(a)redhat.com&gt;

@@ -3573,7 +3572,7 @@ qemuMonitorCPUDefsNew(size_t count)
     g_autoptr(qemuMonitorCPUDefs) defs = NULL;

     defs = g_new0(qemuMonitorCPUDefs, 1);
-    defs->cpus = g_new0(qemuMonitorCPUDefInfoPtr, count);
+    defs->cpus = g_new0(qemuMonitorCPUDefInfo, count);
     defs->ncpus = count;
     return g_steal_pointer(&defs);
 }


    