Re: [libvirt] [PATCH 0/6] conf: qemu: Introduce relaxed config validation
On Tue, May 17, 2016 at 16:55:53 -0400, John Ferlan wrote:
On 05/17/2016 10:25 AM, Peter Krempa wrote:
> Recently I NACKed quite a few patches attempting to add checks to the post
> parse callback infrastructure that would inhbit configs from being loaded
> after daemon restart.
>
> To solve this introduce a new infrastructure that will get called only on
> codepaths that define and start the config leaving the code paths that load
> configs untouched.
>
[...]
Well I see that patch 6 addresses the comments from patch 3 at least
from qemuAttach
The genesis of what is now virDomainDiskDefValidate was to attempt to
extract out one of the qemuCheckDiskConfig checks into an earlier
failure. Looking at that - I would think it would be a prime candidate
to become patch 7 (yeah, I know, patches welcome...). Thinking about
that code though reminds me - virStorageTranslateDiskSourcePool would
need to be called...
At the point where you define a VM you don't really wan't to do that.
The storage pool may not be accessible at that point so the translation
might fail. We'd at least need to be very graceful to that failure and
fall back to the check that doesn't require the pool to be translated.
Peter
Attachments:
- signature.asc (application/pgp-signature — 819 bytes)