On 01/05/2017 02:59 PM, Daniel P. Berrange wrote:
This series adds suppoort for more events
- Event when <metadata> in a domain changes
- Event when virSecret are created/deleted
- Event when virSecret value is changed
The latter two of course required wiring up the secret object
for event support, since we've not had secret events before
now.
Daniel P. Berrange (9):
Add domain event for metadata changes
Introduce secret lifecycle event APIs
conf: add secret event handling
conf: simplify internal virSecretDef handling of usage
remote: implement secret lifecycle event APIs
secret: add support for lifecycle events
examples: add secret events to event demo program
virsh: add secret lifecycle event handling
secret: add support for value change events
daemon/libvirtd.h | 2 +
daemon/remote.c | 276 ++++++++++++++++++++++++++++++++
examples/object-events/event-test.c | 107 +++++++++++++
include/libvirt/libvirt-domain.h | 20 +++
include/libvirt/libvirt-secret.h | 92 +++++++++++
src/Makefile.am | 5 +
src/access/viraccessdriverpolkit.c | 8 +-
src/bhyve/bhyve_driver.c | 7 +
src/conf/domain_event.c | 86 ++++++++++
src/conf/domain_event.h | 10 ++
src/conf/secret_conf.c | 74 ++-------
src/conf/secret_conf.h | 9 +-
src/conf/secret_event.c | 311 ++++++++++++++++++++++++++++++++++++
src/conf/secret_event.h | 65 ++++++++
src/conf/virsecretobj.c | 42 +----
src/datatypes.c | 3 +-
src/datatypes.h | 14 ++
src/driver-secret.h | 14 ++
src/libvirt-secret.c | 129 +++++++++++++++
src/libvirt_private.syms | 9 +-
src/libvirt_public.syms | 2 +
src/lxc/lxc_driver.c | 6 +
src/qemu/qemu_driver.c | 6 +
src/remote/remote_driver.c | 196 ++++++++++++++++++++++-
src/remote/remote_protocol.x | 69 +++++++-
src/remote_protocol-structs | 26 +++
src/secret/secret_driver.c | 82 +++++++++-
src/storage/storage_backend.c | 2 +-
src/test/test_driver.c | 6 +
tools/virsh-domain.c | 25 +++
tools/virsh-secret.c | 225 ++++++++++++++++++++++++++
tools/virsh.pod | 18 +++
32 files changed, 1829 insertions(+), 117 deletions(-)
create mode 100644 src/conf/secret_event.c
create mode 100644 src/conf/secret_event.h
Looking good, except for a small problem in the last patch. Fix it
please before pushing.
ACK series.
Michal