Re: [libvirt] [OSSTEST PATCH 2/2] libvirt: Do not attempt save/restore when migration not advertised

On Wed, Oct 05, 2016 at 06:06:29PM -0600, Jim Fehlig wrote: The thing is that it's not documented. I can't even say "enough", it's more like "at all". You can have a look at it: https://libvirt.org/formatcaps.html It doesn't even talk about <migration_features/>, just <migration/>, but I guess that's the same thing. Since offline migration (as in migrating a domain between hosts without being running) is not that used in the code and talked about, I'm guessing offline means save restore. Looking at the history it was added before the "offline" migration, so it probably means save/restore. To avoid confusion, I would suggest we add either <offline/> or rather <save/> (the naming is not important) and document what it means. And then you can use it exactly how you'd like. And you'll be also sure it means what you need it to mean ;) The patches will be straigh-forward, let me know if I can help anyhow. With that you could straight check for <save/> and <live/> ;) Martin