On Wed, Jul 27, 2011 at 04:37:13PM +0100, Daniel P. Berrange wrote:
On Wed, Jul 27, 2011 at 11:20:42AM -0400, Laine Stump wrote: One further thought, is should we even store 'port' on the listen element. I know technically this lets you configure different port numbers for different interfaces, but this feels somewhat error prone for clients.
eg consider a guest A
<listen addr='10.0.0.1' port='5902'> <listen addr='192.168.0.1' port='5909'>
and guest B
<listen addr='10.0.0.1' port='5904'> <listen addr='192.168.0.1' port='5902'>
And DNS enter 'somehost.example.com' which has two A records
somehost.example.com A 10.0.0.1 somehost.example.com A 192.168.0.1
Connecting to 'somehost.example.com' guest A you need to be very careful not to accidentally get guest B.
It actually gets even worse if you consider a not uncommon DMZ setup where each host is configured with addresses from a private range like 10.0.0.x, but all users connect to the machine using completely different a public IP address. In such a case there'd be no way to reliably determine which port to use for a guest when conencting to the public IP if multiple different ports per VM allowed. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|