Re: [libvirt] [PATCH v3 04/16] conf, schema: add 'id' field for cells
On Wed, Jul 16, 2014 at 12:14:35PM -0600, Eric Blake wrote:
On 07/16/2014 08:42 AM, Martin Kletzander wrote:
> In XML format, by definition, order of fields should not matter, so
> order of parsing the elements doesn't affect the end result. When
> specifying guest NUMA cells, we depend only on the order of the 'cell'
> elements. With this patch all older domain XMLs are parsed as before,
> but with the 'id' attribute they are parsed and formatted according to
> that field. This will be useful when we have tuning settings for
> particular guest NUMA node.
It's not always true that order doesn't matter - for the longest time,
the order of <disk> under <devices> determined boot order. But I agree
that the flexibility of using an id to allow arbitrary ordering can be
nicer than enforcing constant ordering.
I was under the impression that it's determined by the buses the disks
are connected to. Anyway even if that matters, I'm not sure we
guarantee that and if we do, it should be fixed from my POV. But
that's a discussion for another day.
>
> Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com>
> ---
> docs/formatdomain.html.in | 17 +++++----
> docs/schemas/domaincommon.rng | 5 +++
Looks okay to me on the schema side.
Thanks for checking it.
Attachments:
- signature.asc (application/pgp-signature — 819 bytes)