Re: [libvirt] [PATCH] qemu_conf: fix flag value

On 05/12/2010 11:21 PM, Eric Blake wrote: > (gdb) p/x QEMUD_CMD_FLAG_VNET_HOST > $7 = 0xffffffff80000000 > > Oops - that meant we were incorrectly setting QEMU_CMD_FLAG_RTC_TD_HACK > for qemu-kvm-0.12.3 (and probably botching a few other settings as well). > > * src/qemu/qemu_conf.h (QEMUD_CMD_FLAG_VNET_HOST): Avoid sign > extension. > * tests/qemuhelpdata/qemu-kvm-0.12.3: New file. > * tests/qemuhelptest.c (mymain): Add another case. > --- > > It didn't help that the test was truncating output to 31 bits, > and getting confused with sign extension as well. Right. Nice catch, and cleanup of the test as well. ACK