Re: [libvirt] [PATCH v2 06/15] qemu: Defer capability check to command line generation time
On Mon, 2018-02-19 at 14:30 +0100, Peter Krempa wrote:
On Mon, Feb 19, 2018 at 13:21:35 +0000, Daniel Berrange wrote:
> On Mon, Feb 19, 2018 at 02:13:14PM +0100, Peter Krempa wrote:
> > The only situation when we should not fail if QEMU is not installed and
> > you restart libvirtd. Making defined domains disappear is bad.
I think we can all agree on that :)
> A long time back we did have a patch series somewhere that tried
to
> keep domain's loaded, but mark them as "broken" if the QEMU we needed
> was missing. Can't remember why we never went further with it now...
Well in the meanwhile I've made qemuCaps in the PostParse callbacks
optional and it's re-run in such case on startup of the VM. The
validation callbacks are not run when parsing status/config XMLs so it
should mostly work right now properly. (at least it fixed my case when
my binaries failed to exec due to broken deps)
Okay, I'll leave capabilities checks in the validate callback.
--
Andrea Bolognani / Red Hat / Virtualization