Re: [PATCH 1/5] qemu: remove nonsensical sanity check in processNetdevStreamDisconnectedEvent()
On Thu, Apr 10, 2025 at 02:58:26 -0400, Laine Stump wrote:
By definition QEMU will never send a NETDEV_STREAM_DISCONNECTED
event
if it doesn't support the reconnect option for a stream netdev (and
Hmm, nested parenthesis and with a closing one missing :-) I suggest
just s/ (a/. A/
even if, by some comedy of errors, it did send
NETDEV_STREAM_DISCONNECTED in that case, our response to the event
doesn't request anything at all of QEMU (much less something that
would fail if QEMU didn't understand NETDEV_STREAM_DISCONNETED) - it
just starts a new passt process to replace the one that has just been
terminated, so we don't need to check the QEMU capabilities for
QEMU_CAPS_NETDEV_STREAM_RECONNECT.
Signed-off-by: Laine Stump <laine(a)redhat.com>
---
src/qemu/qemu_driver.c | 7 -------
1 file changed, 7 deletions(-)
Reviewed-by: Jiri Denemark <jdenemar(a)redhat.com>