28 Apr
2010
28 Apr
'10
9:09 p.m.
On 04/28/2010 02:27 PM, Chris Lalancette wrote:
When running virsh edit, we are unlinking and setting the tmp variable to NULL before going to the end of the function, meaning that we never free tmp. Since the exit to the function will always unlink and free tmp, just remove this bit of code and let it get done at the end.
ACK. By the way, should we add another patch to warn if unlink() fails for any reason? -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org