Re: [libvirt] [PATCH v2] lxcDomainShutdownFlags and lxcDomainReboot: Cleanup @flags usage

On 01/07/2014 08:20 AM, Michal Privoznik wrote: I'm going to track all four scenarios: A. flags == 0 B. flags == INITCTL C. flags == SIGNAL D. flags == INITCTL | SIGNAL That is, A, B, and D now have initctlRequested true. That is, A, C, and D now have signalRequested true. This says if we have a fatal error while trying initctl, then in scenario B we go to cleanup, otherwise (A or D) we see what else we can do. I'm wondering if we should unconditionally goto cleanup on 'rc < 0', since that implies a pretty major failure in the framework (such as a failed syscall), but I suppose ignoring the error and trying signal anyways also works. Only get here for condition B, at which point the error is correct - we can't shut down the guest by the only means requested. At this point, rc is either 0 (condition C - we skipped the 'if') or the result of our initctl attempt (< 0 for fatal, 0 for unsupported, 1 for succeeded - but rc <=0 is limited to condition A or D since we already went to cleanup on condition B). On the left side of ||, the condition is true for A, C, and D - which is wrong if initctl succeeded [ouch]. On the right side of the ||, the condition is always true for C, as well as sometimes true for A and D (depending on whether initctl succeeded). Simplifying this to 'if (rc == 0)' would fix the broken logic. Still broken; needs a v3. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org