On 4/14/21 10:56 AM, Peter Krempa wrote:
On Wed, Apr 14, 2021 at 10:15:14 +0200, Michal Privoznik wrote:
> When querying guest info via virDomainGetGuestInfo() the
> 'guest-get-disks' agent command is called. It may report disk
> serial number which we parse, but never report nor use for
> anything else.
>
> As it turns out, it may help management application find matching
> disk in their internals.
>
> Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
> ---
> src/libvirt-domain.c | 1 +
> src/qemu/qemu_driver.c | 19 ++++++++++++++-----
> 2 files changed, 15 insertions(+), 5 deletions(-)
>
> diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c
> index 83ff7df9fe..1c244da650 100644
> --- a/src/libvirt-domain.c
> +++ b/src/libvirt-domain.c
> @@ -12561,6 +12561,7 @@ virDomainSetVcpu(virDomainPtr domain,
> * hold the list of PVs, for LUKS encrypted volume this will
> * contain the disk where the volume is placed. (Linux)
> * "disk.<num>.dependency.<num>.name" - a dependency
> + * "disk.<num>.serial" - disk serial number
It's a string though, so s/number/string/ perhaps. Also it's optional.
Ah, good point.
> * "disk.<num>.alias" - the device alias of the disk (e.g.
sda)
> * "disk.<num>.guest_alias" - optional alias assigned to the
disk, on Linux
> * this is a name assigned by device mapper
Missing virsh manpage update.
I had feeling that I forgot something :-) Let me respin.
Michal