On Mon, Nov 28, 2016 at 11:28:10AM -0500, John Ferlan wrote:
[...]
BLOCK_IOTUNE_ASSIGN(SIZE_IOPS_SEC, size_iops_sec);
+ if (*nparams < maxparams && + virTypedParameterAssign(¶ms[(*nparams)++], + VIR_DOMAIN_BLOCK_IOTUNE_GROUP_NAME, + VIR_TYPED_PARAM_STRING, + reply.group_name) < 0) + goto endjob; +
As Martin pointed out in v1 review , this could still become BLOCK_IOTUNE_ASSIGN, this way it just sort of bothers the OCD inside me. Would you mind adjusting it? :)
I get the OCD thing; however, as I pointed out in my response to Martin the macro uses VIR_TYPED_PARAM_ULLONG while this particular field is a VIR_TYPED_PARAM_STRING
Also, this^^ hunk above will later (during serialization) crash the daemon, since reply is uninitialized in this function so that needs to be adjusted as well.
I'm not getting a libvirtd crash... Do you have a trace?
#0 0x00007ffff35b1a28 in raise () from /lib64/libc.so.6 #1 0x00007ffff35b362a in abort () from /lib64/libc.so.6 #2 0x00007ffff35f4dea in __libc_message () from /lib64/libc.so.6 #3 0x00007ffff35fd22a in _int_free () from /lib64/libc.so.6 #4 0x00007ffff360078c in free () from /lib64/libc.so.6 #5 0x00007ffff71fafd5 in virFree (ptrptr=0x7fffd0306de8) at util/viralloc.c:582 #6 0x00007ffff7287f40 in virTypedParamsClear (params=0x7fffd03068b0, nparams=20) at util/virtypedparam.c:1298 #7 0x00007ffff7287f75 in virTypedParamsFree (params=0x7fffd03068b0, nparams=20) at util/virtypedparam.c:1317 #8 0x000055555559b01d in remoteDispatchDomainGetBlockIoTune (server=0x555555814300, client=0x55555584cad0, hdr=0x55555584d5e0, rerr=0x7fffe41d8ac0, args=0x7fffd000a840, ret=0x7fffd0000bf0) at remote.c:3071 #9 0x0000555555579c32 in remoteDispatchDomainGetBlockIoTuneHelper (server=0x555555814300, client=0x55555584cad0, msg=0x55555584d5e0, rerr=0x7fffe41d8ac0, args=0x7fffd000a840, ret=0x7fffd0000bf0) at remote_dispatch.h:5091 #10 0x00007ffff73ed63b in virNetServerProgramDispatchCall (prog=0x55555580b7a0, server=0x555555814300, client=0x55555584cad0, msg=0x55555584d5e0) at rpc/virnetserverprogram.c:437 #11 0x00007ffff73ed1a1 in virNetServerProgramDispatch (prog=0x55555580b7a0, server=0x555555814300, client=0x55555584cad0, msg=0x55555584d5e0) at rpc/virnetserverprogram.c:307 #12 0x00005555555b8e66 in virNetServerProcessMsg (srv=0x555555814300, client=0x55555584cad0, prog=0x55555580b7a0, msg=0x55555584d5e0) at rpc/virnetserver.c:148 #13 0x00005555555b8f2a in virNetServerHandleJob (jobOpaque=0x55555584b850, opaque=0x555555814300) at rpc/virnetserver.c:169 #14 0x00007ffff72832c4 in virThreadPoolWorker (opaque=0x5555558204c0) at util/virthreadpool.c:167 #15 0x00007ffff7282853 in virThreadHelper (data=0x555555822060) at util/virthread.c:206 #16 0x00007ffff394561a in start_thread () from /lib64/libpthread.so.0 #17 0x00007ffff367f5fd in clone () from /lib64/libc.so.6
John
[...]