Re: [libvirt] [PATCH 1/2] xen: add error handling to UUID parsing
On 10/07/2011 04:18 AM, Guido Günther wrote:
>>> > >>ACK to the concept, once we decide on the
correct error code.
> >
> > I think we've decided.
(Hopefully) final version attached. I've left the first error as
INTERNAL_ERROR since this it's there do detect false function
parameters.
Yes, you got that part right.
Subject: [PATCH] xen: add error handling to UUID parsing
otherwise a missing UUID in a domain config just shows:
error: An error occured, but the cause is unknown
s/occured/occurred/
I don't see that typo in the source code for virterror, so I suspect you
were re-typing instead of copy-and-paste. (That said, I'll be pushing a
trivial patch to fix up the places that _do_ have a typo.)
Now we have:
error: configuration file syntax error: config value uuid was missing
ACK.
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org