On 11/12/14 18:40, Michal Privoznik wrote:
On 06.11.2014 15:31, Eric Blake wrote:
On 11/06/2014 02:01 PM, Michal Privoznik wrote:
This flag can be used to sync the domain's time right after domain CPUs are started. It's basically backing call of two subsequent APIs into one:
1) virDomainResume(dom) 2) virDomainSetTime(dom, 0, 0, VIR_DOMAIN_TIME_SYNC)
Signed-off-by: Michal Privoznik <mprivozn@redhat.com> --- include/libvirt/libvirt-domain.h | 7 +++++++ src/libvirt-domain.c | 18 ++++++++++++------ src/qemu/qemu_driver.c | 20 +++++++++++++++++++-
Still missing a change to remote_protocol.x to add proper ACL checking of the flag (see my reply to v1).
Okay, fixed in my local branch. Any other comments?
For this one I'm still not convinced this is a good idea to combine the two operations. I'd still like to have a second opinion on that. Code-wise you've solved all my requests from the previous version. 1/2 ACK. Peter