On Wed, Oct 13, 2010 at 11:12:49AM +0530, Nikunj A. Dadhania wrote:
On Tue, 12 Oct 2010 19:27:05 +0200, Daniel Veillard <veillard@redhat.com> wrote:
On Fri, Oct 08, 2010 at 05:47:03PM +0530, Nikunj A. Dadhania wrote:
From: Nikunj A. Dadhania <nikunj@linux.vnet.ibm.com>
v4: * prototype change: add unsigned int flags, regenerate files
v3: * Squased all the remote driver changes to one single big patch and auto-generated is around 40% * Implements domainSetMemoryParameters and domainGetMemoryParameters for remote driver daemon/remote.c src/remote/remote_driver.c
* Auto generate the files using rpcgen and helper scripts in daemon/ directory src/remote/remote_protocol.x daemon/remote_dispatch_args.h daemon/remote_dispatch_prototypes.h daemon/remote_dispatch_ret.h daemon/remote_dispatch_table.h src/remote/remote_protocol.c src/remote/remote_protocol.h
Acked-by: "Daniel P. Berrange" <berrange@redhat.com> Signed-off-by: Nikunj A. Dadhania <nikunj@linux.vnet.ibm.com> [...] + nparams = args->params.params_len; + nparams = args->flags;
obvious bug: flags = args->flags; Oops :) - C&P
That reminds me that I didn't see flags being checked against 0 on the QEmu and LXC drivers, we should check them !
I will take care of this.
virCheckFlags(0, -1); as in qemuDomainGetBlockInfo() for example.
With that done, I think I can ACK the whole serie, and pushed it, but there is still a number of small TODOs for which I would appreciate patches,
thanks a lot !
Thanks a lot to you and Daniel Berrange. Both of you have spend a lot of time on reviewing and on top of that fixing the patches as well.
Well this would have been a bit simpler if you had used "make syntax-check " from the beginning, but most of the time spent was actually code review and fixes, not those trivial issues :-) Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/