Re: [PATCH 29/33] qemu: Move qemuDomainDefault*() functions together
On Wed, Jan 24, 2024 at 20:37:49 +0100, Andrea Bolognani wrote:
Most of the functions responsible for choosing architecture and
machine specific defaults are already close to one another, with
just a couple of strays. Having everything in one place will
hopefully make it harder to miss updating any of the functions
when new architectures are being introduced.
Too bad that the code is using a eclectic selection of ARCH_IS_* macros
together with checkers such as qemuDomainIsRISCVVirt etc, because it's
hard to create a proper fix which would be a properly typed switch
statement, where the compiler would enforce what you want to achieve
here.
Also too bad that the list of arches is *massive* to have it everywhere,
despite the fac that we effectively ignore a half of them.
Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
---
src/qemu/qemu_domain.c | 151 ++++++++++++++++++++---------------------
1 file changed, 75 insertions(+), 76 deletions(-)
Reviewed-by: Peter Krempa <pkrempa(a)redhat.com>