On 3/23/21 7:03 AM, Ján Tomko wrote:
On a Monday in 2021, Daniel Henrique Barboza wrote:
Commit ac87d3520ad5 consolidated common cgroup code between the QEMU and lxc drivers in domain_cgroup.c. In this process, in virDomainCgroupSetupDomainBlkioParameters(), a call to virCgroupGetBlkioWeight() went missing.
The result is that 'virsh blkiotune' is setting the blkio.weight for the guest in the host cgroup, but not on the domain XML, because virCgroupGetBlkioWeight() is also used to write the blkio.weight value in the domain object.
Fix it by adding the virCgroupGetBlkioWeight() call in the virDomainCgroupSetupDomainBlkioParameters() helper.
Fixes: 5493217b940ee9ea72b581270adb3ab9ba245148
fatal: bad object 5493217b940ee9ea72b581270adb3ab9ba245148
I have no idea where this commit is from. The strangest thing is that I referenced the right commit up there \_o_/ I'll change it to ac87d3520ad542d558854a72b0ae0a81fddc6747 before pushing.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1941407 Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com> --- src/hypervisor/domain_cgroup.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Thanks! DHB
Jano