Re: [libvirt] [PATCH] conf: Don't deref NULL actual network in virDomainNetGetActualHostdev()

On 09/04/2013 09:37 AM, Peter Krempa wrote: > In commit 991270db99690 I've used virDomainNetGetActualHostdev() to get > the actual hostdev from a network when removing the network from the > list to avoid leaving the hostdev in the list. I didn't notice that this > function doesn't check if the actual network is allocated and > dereferences it. This crashes the daemon when cleaning up a domain > object in early startup phases when the actual network definition isn't > allocated. When the actual definition isn't present, the hostdev that > might correspond to it won't be present anyways so it's safe to return > NULL. > > Thanks to Cole Robinson for noticing this problem. > --- > src/conf/domain_conf.c | 1 + > 1 file changed, 1 insertion(+) ACK.