Re: [libvirt] [PATCH 8/9] wip: start virtiofsd
On Fri, Nov 1, 2019 at 1:18 PM Ján Tomko <jtomko(a)redhat.com> wrote:
+ if (qemuSecuritySetDaemonSocketLabel(driver->securityManager,
vm->def) < 0)
+ goto cleanup;
+ fd = qemuOpenChrChardevUNIXSocket(chrdev);
+ if (fd < 0)
+ goto cleanup;
+ if (qemuSecurityClearSocketLabel(driver->securityManager, vm->def) < 0)
+ goto cleanup;
qemuSecurityClearSocketLabel() is not called in the
qemuOpenChrChardevUNIXSocket() error code path. Is this correct?
+static void
+qemuExtVirtioFSdStop(virQEMUDriverPtr driver,
+ virDomainObjPtr vm,
+ virDomainFSDefPtr fs)
+{
The daemon stops automatically when the vhost-user socket is closed by
QEMU. Is it necessary to implement an explicit stop function?
Stefan