Re: [libvirt] [PATCH] qemu: enable multifunction for older qemu

At 10/06/2011 05:52 AM, Eric Blake Write: > Now that RHEL 6.2 Beta is out, it would be nice to test multifunction > devices on that platform. This changes things so that the multifunction > cap bit can be set in two different ways: by version comparison (needed > for qemu 0.13 which lacked a -device query), and by -device query > (provided by qemu.git and backported to the RHEL beta build of > qemu-kvm which still claims to be a modified 0.12, and therefore needed > for RHEL). >

> +++ b/src/qemu/qemu_capabilities.c > @@ -1264,6 +1264,8 @@ qemuCapsParseDeviceStr(const char *str, virBitmapPtr flags) > /* Features of given devices. */ > if (strstr(str, "pci-assign.configfd")) > qemuCapsSet(flags, QEMU_CAPS_PCI_CONFIGFD); > + if (strstr(str, "pci-assign.multifunction")) > + qemuCapsSet(flags, QEMU_CAPS_PCI_MULTIFUNCTION); Only qemu-kvm has pci-assign, so I think it is better to check 'virtio-blk-pci.multifunction'.