Re: [libvirt] [PATCH] cfg.mk: Introduce rule for setlocale()

On Wed, Jun 04, 2014 at 10:59:08AM +0200, Michal Privoznik wrote: > In the past we had some issues where setlocale() was called without > corresponding include of locale.h. While on some systems this may > work, on others the compilation failed. We should have a syntax-check > rule for that to prevent this from happening again. > > Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com&gt; > --- > cfg.mk | 9 +++++++++ > 1 file changed, 9 insertions(+) >

> +# Require #include <locale.h> in all files that call setlocale() > +sc_require_locale_h: > + @for i in $$($(VC_LIST_EXCEPT) | grep '\.[chx]$$'); do \ > + if test -z "$$(grep setlocale $$i)" ; then continue; fi; \ Why not: if ! grep -q setlocale $$i; then continue; fi