Re: [libvirt] [PATCH] maint: make Red Hat copyright notices consistent
Eric Blake wrote:
Spell out 'Red Hat, Inc.':
git grep -i 'Copyright.*Red Hat' | grep -v Inc
Include (C) consistently:
git grep -i 'Copyright [^(].*Red Hat'
* src/lxc/lxc_container.c: Update copyright formatting.
* src/node_device/node_device_udev.c: Likewise.
* src/node_device/node_device_udev.h: Likewise.
* src/xen/xend_internal.h: Likewise.
* src/xen/xm_internal.c: Likewise.
* src/xen/xm_internal.h: Likewise.
* tests/xmconfigtest.c: Likewise.
* tests/object-locking.ml: Likewise.
ACK.
Mechanical, comment-only change.
One suggestion: consistency-adding changes are great,
but they're worth much more when accompanied by syntax-check
style rules that ensure future consistency, too.
On that note, after your changes, there are only two violations:
$ git grep -i 'Copyright [^(].*Red Hat'
tools/virt-pki-validate.in:Copyright 2006-2009 by Red Hat, Inc
tools/virt-xml-validate.in:Copyright 2009 by Red Hat, Inc
So I'll fold in fixes:
diff --git a/tools/virt-pki-validate.in b/tools/virt-pki-validate.in
index 3e8c642..b3fc986 100755
--- a/tools/virt-pki-validate.in
+++ b/tools/virt-pki-validate.in
@@ -297,7 +297,7 @@ Alternatively report bugs to your software distributor / vendor.
=head1 COPYRIGHT
-Copyright 2006-2009 by Red Hat, Inc
+Copyright (C) 2006-2009 by Red Hat, Inc
=head1 LICENSE
diff --git a/tools/virt-xml-validate.in b/tools/virt-xml-validate.in
index 03bd1a1..19a68b7 100644
--- a/tools/virt-xml-validate.in
+++ b/tools/virt-xml-validate.in
@@ -134,7 +134,7 @@ Alternatively report bugs to your software distributor / vendor.
=head1 COPYRIGHT
-Copyright 2009 by Red Hat, Inc
+Copyright (C) 2009 by Red Hat, Inc
Copyright 2009 by Daniel P. Berrange
=head1 LICENSE