Re: [libvirt] [PATCH 17/18] util: virstoragefile: Don't mangle data stored about directories
On 04/20/2014 04:13 PM, Peter Krempa wrote:
Don't remove detected metadata about directory based storage
volumes.
---
src/util/virstoragefile.c | 7 ++-----
tests/virstoragetest.c | 3 +++
2 files changed, 5 insertions(+), 5 deletions(-)
ACK.
+++ b/tests/virstoragetest.c
@@ -709,6 +709,9 @@ mymain(void)
testFileData dir = {
.pathRel = "dir",
.pathAbs = absdir,
+ .path = canondir,
+ .relDirRel = ".",
+ .relDirAbs = datadir,
.type = VIR_STORAGE_TYPE_DIR,
.format = VIR_STORAGE_FILE_DIR,
};
Ah, I'm glad I spent time improving the testsuite. This entire series
has been much easier to justify and easier to work with because of the
tests.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 604 bytes)