Re: [libvirt] [Qemu-devel] [PATCH v4] Add support for fd: protocol
On 08/22/2011 11:38 AM, Christoph Hellwig wrote:
I'm still totally against this. FD passing is a nice feature for
sandboxing,
but the passing should be between closely cooperating programs. We'll
need a tool shipped from the qemu source tree to open and set up the
FDs, and not someone external. With that setup in place we can use
a protocol similar to the various OpenBSD privilegue separated deaemons
to also allow reopening / snapshots / etc.
Opening fds in libvirt and passing them into qemu is exactly the wrong way,
and just cements the current horrors where libvirt duplicates parsing
of image format headers.
This is following suit with exiting support that passes an fd for a TAP
interface. Libvirt already passes a file descriptor to Qemu via '-net
tap,fd='. Are you against that as well?
Regards,
Corey