On Fri, Jun 08, 2018 at 11:57:43AM +0200, Andrea Bolognani wrote:
On Fri, 2018-06-08 at 10:45 +0100, Daniel P. Berrangé wrote:
On Fri, Jun 08, 2018 at 11:41:54AM +0200, Andrea Bolognani wrote:
Regardless of the nits pointed out above, this commit will fix the build issue on Fedora but not on CentOS 7, where neither perl-generators nor perl-interpreter exist: you need to also tweak libvirt-perl's spec so that those packages are only required on Fedora.
I sent a patch for that yesterday....
https://www.redhat.com/archives/libvir-list/2018-June/msg00540.html
Must have missed it :)
Looking at it now, in the interest of not having to tweak this again once "future RHEL" is releases I suggest rewriting the mapping as
perl-generators: rpm: perl-generators CentOS6: CentOS7:
Yeah looks good.
I wonder if we should handle perl-interpreter explicitly as well? Perhaps it's okay to assume perl will either provide or drag in perl-interpreter, at least for the time being.
Yeah, 'perl' (and a million other things) pull in perl-interpretor so I didn't feel a need to add it. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|