Re: [libvirt] [PATCH 1/2] tests: Add mocking for qemuMonitorJSONGetSEVCapabilities

On 1/23/19 3:59 PM, John Ferlan wrote: > Commit d4005609 added "altered" capabilities replies output > in order to fake a 'query-sev-capabilities' reply from QEMU. > This worked fine for the 2.12 processing for qemuxml2argvtest > until the next capabilities was generated and the output wasn't > doctored. Thus commit 6c50cef8 used DO_TEST_CAPS_VER against > 2.12.0 noting that the 2.12.0 capabilities were hand edited > to add AMD specific output into an Intel capabilities reply. > > Instead of "altering" the output or running against a specific > reply that we know was altered, let's instead use the mocking > capabilities to check the return from a real call and mock up > return data if we determine the returned real call doesn't > support compiled-in SEV. This way the qemuxml2argvtest can > use the DO_TEST_CAPS_LATEST which runs only for x86_64 to > determine that noting in "latest" changes with respect to > SEV and effectively fake things out to generate expected > output ensuring that other changes to libvirt/qemu don't > somehow affect SEV support. > Seems reasonable to me. This is an improvement over the current state that appears to implicitly require manually editing caps replies to list SEV support. The downside is that there's no way to test lack of SEV support now, but we weren't testing that anyways it seems. More complete solutions adding caps files for both intel and AMD sound nicer but are also a lot more work.

Still it seems like it would be worthwhile to have actual AMD capabilities output in the test suite, even if it's just a single example. But I guess we would need to fine someone with the proper hardware and extend the macros in qemuxml2argv to handle it. Anyways...