Re: [libvirt] [PATCH v6] network: Add network bandwidth support to ethernet interfaces

On 11/20/14, 5:43 AM, "Vasiliy Tolstov" <v.tolstov(a)selfip.ru&gt; wrote: >2014-11-20 7:58 GMT+03:00 Anirban Chakraborty <abchak(a)juniper.net&gt;: >> Your original error message was that qemu couldn¹t find a tap device. >>So, >> I am not sure how the above error relates to your original error. >> Can you write your detail configuration setup and the steps you have >>taken >> to get at this error? > > >If i'm not wrong error goes from: >qemuBuildInterfaceCommandLine builds interface command line and before >qemu started tries to add tap device to tc, but tap created later via >qemu (in my case). >I think that virNetDevBandwidthSet needs to be run after qemu started. Please look at the code. Tap device is not created for network interface type ethernet. virNetDevTapCreate creates the tap device, which eventually gets called from qemuNetworkIfaceConnect and this applies to interface types network or bridge. For ethernet type interfaces, the onus is on the user to create the tap device in the first place before configuring bandwidth for it.

So, there is no point in changing any code here, if the tap device doesn’t exist and the vm configuration file has an entry for it, then libvirt is supposed to throw the error message to let the user know about it. Anirban