On Wed, 2020-11-18 at 16:58 -0300, Daniel Henrique Barboza wrote:
A previous patch removed the pSeries NVDIMM align that wasn't being done properly. This patch reintroduces it in the right fashion, making it reliant on VIR_DOMAIN_DEF_PARSE_ABI_UPDATE. This makes it complying with the intended design defined by commit c7d7ba85a624.
Since the PARSE_ABI_FLAG is more restrictive than checking for
s/PARSE_ABI_FLAG/PARSE_ABI_UPDATE flag/
+++ b/tests/qemuxml2argvdata/memory-hotplug-nvdimm-ppc64-abi-update.xml @@ -0,0 +1,50 @@ + <devices> + <emulator>/usr/bin/qemu-system-ppc64</emulator> + <controller type='usb' index='0'> + <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x0'/> + </controller>
This part could be simplified a bit. Please take a look at https://www.redhat.com/archives/libvir-list/2020-December/msg00244.html which I'm hoping you'll agree to rebase your series on top of.
+++ b/tests/qemuxml2xmltest.c @@ -1240,6 +1240,13 @@ mymain(void) + DO_TEST_FULL("memory-hotplug-nvdimm-ppc64-abi-update", WHEN_BOTH, + ARG_PARSEFLAGS, VIR_DOMAIN_DEF_PARSE_ABI_UPDATE, + ARG_QEMU_CAPS, + QEMU_CAPS_DEVICE_SPAPR_PCI_HOST_BRIDGE, + QEMU_CAPS_DEVICE_NVDIMM, + QEMU_CAPS_LAST);
Please add this new test to qemuxml2argv as well. -- Andrea Bolognani / Red Hat / Virtualization