Re: [libvirt PATCH 7/9] util: relax requirement for logind to be running

On Thu, Jun 22, 2023 at 10:23:57AM +0200, Peter Krempa wrote: > On Wed, Jun 21, 2023 at 14:32:30 +0100, Daniel P. Berrangé wrote: > > + /* > > + * Want to use logind if: > > + * - logind is already running > > + * Or > > + * - logind is not running, but this is a systemd host > > + * (rely on dbus activation) > > + */ > > if ((ret = virGDBusIsServiceRegistered("org.freedesktop.login1")) == -1) > > return ret; > > > > + if (ret == -2) { > > + if ((ret = virGDBusIsServiceRegistered("org.freedesktop.systemd1")) == -1) > > + return ret; > > + } > > Why not simply just check that we are on a systemd host? Can logind be > used without systemd? I believe it can. I recall that when Debian supported a choice between systemd and sysvinit, logind could still be used in the sysvinit scenario in order to support GNOME which had a mandatory dep on logind. So I wasn't comfortable entirely removing the check for logind.