On Thu, Jan 19, 2012 at 01:32:08PM -0700, Eric Blake wrote:
On 01/18/2012 12:38 AM, Taku Izumi wrote:
I am now wondering if we should do this in a different way. ie if there is some XML configuration parameter for the <disk> that indicates the need for rawio, then libvirt could automatically ensures that we add CAP_SYS_RAWIO when starting QEMU.
I see. You say if a guest has the following XML configuration, "CAP_SYS_RAWIO" capability is automatically added to it, right?
<disk type='block' device='lun'>
Yes, that actually seems reasonable, especially since device='lun' is brand new, and so far, is really the only reason that we'd need CAP_SYS_RAWIO.
Does device='lun' really require CAP_SYS_RAWIO ? I hadn't seen that mentioned before now Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|