Re: [PATCH v2 06/27] conf: Require nvdimm path in validate step
On Thu, Dec 03, 2020 at 13:36:09 +0100, Michal Privoznik wrote:
Our code expects that a nvdimm has a path defined always. And the
parser does check for that. Well, not fully - only when parsing
<source/> (which is an optional element). So if the element is
not in the XML then the check is not performed and the assumption
is broken. Verify in the memory def validator that a path was
set.
Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
---
src/conf/domain_conf.c | 12 +++++++-----
src/security/security_apparmor.c | 6 ------
2 files changed, 7 insertions(+), 11 deletions(-)
We don't validate existing configs, but removing the apparmor check is
okay since you can't have an running VM with broken config due to it and
the check will be done when starting the VM.
Reviewed-by: Peter Krempa <pkrempa(a)redhat.com>