Re: [libvirt] [PATCH v2] esx: Support VLAN tags in virtual network port groups
On Sun, Aug 26, 2012 at 6:36 AM, Matthias Bolte
<matthias.bolte(a)googlemail.com> wrote:
---
v2: Use network level VLAN config if there is no portgroup specific VLAN
config given.
src/esx/esx_network_driver.c | 65 ++++++++++++++++++++++++++++++++++++++---
1 files changed, 60 insertions(+), 5 deletions(-)
This is really more of a nitpick but I would personally like to see
something like
/* VMWare ESX utilizes the VLAN ID of 4095 to mean that this port is
in trunk mode */
#define ESX_VLAN_TRUNK 4095
or something similar. Then removing all the hardcoded uses of 4095
throughout the code. Magical hardcoded values are often non-obvious as
to what they mean but a define gives us a chance to have a little
documentation. Also it prevents potential typos from sneaking in (e.g.
4059 or 4096).
Just a thought.
--
Doug Goldstein