Re: [libvirt] [PATCH] qemu: Fix a regression of domain save

1 Sep 2011

于 2011年09月01日 16:14, Osier Yang 写道:
...
* src/qemu/qemu_driver.c - qemuDomainSaveInternal: Return directly
will keep the domain object locked.
To be more descriptive, will add the commit which introduces the regression
when commit.
...
---
 src/qemu/qemu_driver.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 4e8c691..a150b08 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -2223,7 +2223,7 @@ qemuDomainSaveInternal(struct qemud_driver *driver, virDomainPtr dom,
     if (qemuProcessAutoDestroyActive(driver, vm)) {
         qemuReportError(VIR_ERR_OPERATION_INVALID,
                         "%s", _("domain is marked for auto destroy"));
-        return -1;
+        goto cleanup;
     }
memset(&header, 0, sizeof(header));

    