On 5/15/20 11:01 AM, Peter Krempa wrote:
On Fri, May 15, 2020 at 16:51:28 +0800, Yi Wang wrote:
From: LiaoPingfang <liao.pingfang@zte.com.cn>
First of all, there is no "configure" file. We need use autogen.sh at first to create "configure" file. Then in autogen.sh "configure" will be executed according to user as root or non-root.
NACK, autogen needs to be run when running from a git checkout, but is not present when building from a tarball.
You can modify that statement but blankly stating that autogen needs to be run is wrong.
Well, I guess we need two sections. Thing is, README serves two goals since we switched to gitlab. The first one, the old one - README as part of release tarball, but it also gained new purpose - landing webpage for developers who browse gitlab (that is why we have images in the .rst). Therefore, what we should do is to have a section that covers "building from git" and another one "building from a tarball". Note that we already cover these in [1], so maybe after all drop all compile info in favour of the link? Michal 1: https://libvirt.org/compiling.html