Re: [libvirt] PATCH: Fix python binding for listing storage pools/volumes
On Wed, May 28, 2008 at 10:12:42AM -0400, Daniel Veillard wrote:
On Fri, May 23, 2008 at 04:29:59PM +0100, Daniel P. Berrange wrote:
> On Fri, May 23, 2008 at 04:17:26PM +0100, Daniel P. Berrange wrote:
> > The python binding for the APIs to list storage pools and volumes has a
> > hand written C layer, but an auto-generated python layer. The latter was
> > auto-generating incorrectly, so this patch overrides its API contract
> > making the generator work correctly.
>
> The getinfo APIs need overriding too...
Looks fine, so we added to the C module but didn't override in the XML, right ?
Yes, I missed it because the generator was quite happy generating code
for them. I just didn't notice the code it was generating was broken !
Dan
--
|: Red Hat, Engineering, Boston -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|