Re: [libvirt PATCH v2 1/1] meson: Drop RPATH usage

On Wed, Aug 19, 2020 at 01:22:58PM +0200, Pavel Hrdina wrote: So I managed to remember what was the issue. If you run install libvirt into custom directory like this: meson build --prefix /my/custom/dir ninja -C build install and after that running: /my/custom/dir/bin/virsh will fail with: /lib64/libvirt.so.0: version `LIBVIRT_PRIVATE_6.7.0' not found (required by ./bin/bin/virsh) This is what autotools did by default as well and I did not know that there is an option --disable-rpath as it's not in output of `./configure --help`. If we don't care about the use case of installing libvirt into custom prefix and breaking it it should be OK to remove this from meson but my guess is that we should not do it. We can add an option like it was proposed in V1 but with the following changes. In meson.build we would have this: if get_option('rpath') libvirt_rpath = libdir else libvirt_rpath = '' endif and all places with install_rpath would use libvirt_rpath instead of libdir directly and we would not have to have the craze if-else. Pavel