
On mer, 2013-12-18 at 14:45 +0000, Ian Jackson wrote:
Jim Fehlig writes ("Re: libxl: cannot connect to PV console"):
Dario Faggioli wrote:
[xen@ghoul3 libvirt.git]$ sudo ./tools/virsh console fedora20_64 Connected to domain fedora20_64 Escape character is ^] error: internal error: cannot find character device (null)
Looking at libxlDomainOpenConsole() in src/libxl/libxl_driver.c, it currently only supports a serial console. Do you have one defined in these domains? E.g.
If this is the root cause, it's a pretty bad error message.
Indeed.
Should I or Dario take a look at the libvirt code to see if we can improve it ?
Looks like it's this piece of code, in src/libxl/libxl_driver.c: libxlDomainOpenConsole(..) ... if (vm->def->nserials) chr = vm->def->serials[0]; if (!chr) { virReportError(VIR_ERR_INTERNAL_ERROR, _("cannot find character device %s"), NULLSTR(dev_name)); goto cleanup; } ... } I guess I can send a patch to turn that message into something like "cannot find any serial console define for the domain", either always or in the specific case where vm->def->serials[0] is NULL, as I feel like the "character device (null)" part is the worst and most misleading. At the same time, I'd be interested in figuring out why this does not work / stopped working. I'll investigate more. Regards, Dario -- <<This happens because I choose it to happen!>> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)