On 03/18/2016 09:26 AM, Peter Krempa wrote:
After the refactor in the previous patch, the functions are no longer required.
Functions no longer required for attaching SCSI disks since QEMU_CAPS_DEVICE is expected.
--- src/qemu/qemu_hotplug.c | 1 - src/qemu/qemu_monitor.c | 16 -------- src/qemu/qemu_monitor.h | 6 --- src/qemu/qemu_monitor_text.c | 98 -------------------------------------------- src/qemu/qemu_monitor_text.h | 5 --- 5 files changed, 126 deletions(-)
diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index ac359da..bc2336a 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -562,7 +562,6 @@ qemuDomainAttachSCSIDisk(virConnectPtr conn, virDomainObjPtr vm, virDomainDiskDefPtr disk) { - size_t i;
^^ Belongs in previous patch; otherwise, git bisect is broken
qemuDomainObjPrivatePtr priv = vm->privateData; char *drivestr = NULL; char *devstr = NULL;
[...] ACK w/ change (yes, that implies patch 1 ACK) John