Re: [libvirt] [PATCH] lxc: trivially support DomainHasManagedSaveImage
On 01/15/2015 03:20 PM, Daniel P. Berrange wrote:
On Thu, Jan 15, 2015 at 03:12:01PM +0100, Ján Tomko wrote:
> Return 0 instead of ERR_NO_SUPPORT to avoid spamming daemon logs
> when 'virsh dominfo' is run.
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1095637
> ---
> src/lxc/lxc_driver.c | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
What about all the other virt drivers too ? If virsh is going to do
this, then we really ought to make every virt driver have this same
no-op impl. The bug only reports it against LXC since that's what
the reporter tested, but anyone could see it against other virt
drivers
The problem is - I can't tell if a driver doesn't have any ManagedSave* APIs
implemented because nobody took the time to implement them in libvirt, or
because the hypervisor does not support it.
For example if VirtualBox used without libvirtd can do a save, I think it
would be wrong to always return 0 in our vbox driver.
Jan
Attachments:
- signature.asc (application/pgp-signature — 819 bytes)