Re: [libvirt] [PATCH 9/9] Add 'lxc-enter-namespace' command to virsh

On 12/21/2012 10:08 AM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" <berrange(a)redhat.com&gt; > > Add a 'lxc-enter-namespace' command which accepts a domain name > and then a command + args to run, attached to the container > > eg > > virsh -c lxc:/// lxc-enter-namespace demo -- /bin/ps -auxf > > +static const vshCmdOptDef opts_lxc_enter_namespace[] = { > + {"domain", VSH_OT_DATA, VSH_OFLAG_REQ, N_("domain name, id or uuid")}, > + {"timeout", VSH_OT_INT, VSH_OFLAG_REQ_OPT, N_("timeout seconds. must be positive.")}, > + {"async", VSH_OT_BOOL, 0, N_("execute namespace without waiting for timeout")}, > + {"block", VSH_OT_BOOL, 0, N_("execute namespace without timeout")}, Oh, and I don't see timeout, async, or block actually used in the implementation; did you mean to wire them up? Waiting for v2.