On a Sunday in 2020, Laine Stump wrote:
after making all virFirewall objects use g_autoptr().
Signed-off-by: Laine Stump <laine(a)redhat.com>
---
src/network/bridge_driver_linux.c | 27 +++++++------------
src/nwfilter/nwfilter_ebiptables_driver.c | 32 +++++++----------------
src/util/virebtables.c | 16 ++----------
src/util/viriptables.c | 8 ++----
4 files changed, 22 insertions(+), 61 deletions(-)
[...]
diff --git a/src/util/virebtables.c b/src/util/virebtables.c
index 69483f35ec..610c399414 100644
--- a/src/util/virebtables.c
+++ b/src/util/virebtables.c
[...]
@@ -128,12 +121,7 @@ ebtablesForwardAllowIn(ebtablesContext *ctx,
"--jump", "ACCEPT",
NULL);
- if (virFirewallApply(fw) < 0)
- goto cleanup;
-
- ret = 0;
- cleanup:
- return ret;
+ return virFirewallApply(fw);
Double space.
}
/**
Reviewed-by: Ján Tomko <jtomko(a)redhat.com>
Jano