2 Jan
2017
2 Jan
'17
2:29 p.m.
On Mon, 2017-01-02 at 13:10 +0100, Michal Privoznik wrote:
I vote for Michal's approach as it doesn't require us to disable VIR_TEST_REGENERATE_OUTPUT.
Well, it does. Kinda. You *must not* regenerate output on FreeBSD with his patch, so it should be explicitly disabled.
Really? I think it works well even if you do regenerate output there. I mean, my patch fixes the output of the actual configuration, so that it will always contain 'lo' instead of 'lo0'. And test output regeneration is done after that. With 'lo'.
I just checked and indeed, with Michal's patches that have since been pushed, VIR_TEST_REGENERATE_OUTPUT works perfectly fine even when run on FreeBSD. -- Andrea Bolognani / Red Hat / Virtualization